image: Take explicit dependency on util-linux for uuidgen and gzip #1262
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
uuidgen is moderately useful to a consumer to generate a unique cluster id, but we are in the process of removing util-linux which contains uuidgen from the base image because it brings in about 30M of compressed dependencies above what the new minimal base includes (timezone data, systemd libs, a few others). For now, update the image to make the dependency explicit, although we may want to remove uuidgen in the future or make it a subcommand of the install. Gzip is used to compress artifacts in CI and is also moderately useful for an admin who wants to compress logs.
smarterclayton
force-pushed
the
depend_util_linux
branch
from
bfec7cc to
71d199c
Compare
smarterclayton
changed the title
But we don't want users generating cluster IDs, see #1057.
This is for CI? I'd rather copy the statically linked |
|
Right now, everyone who uses installer expects gzip and uuidgen to be there. The way that we stage these changes out is that we move the dependency to the images using it, then it's up to that team to remove. So this team will own reverting this once they've cleared up the usages that have accumulated. |
|
@smarterclayton: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Known flakes, force merging so we can continue to test the UBI switch. |
… gzip" This reverts commit 71d199c, openshift#1262 Since openshift/release@00d7b3f31 (ci-operator/templates/openshift: Use IMAGE_TESTS for teardown gzip, 2019-02-19, openshift/release#2911), the release repository no longer users the installer image for the teardown containers.
uuidgen is moderately useful to a consumer to generate a unique
cluster id, but we are in the process of removing util-linux which
contains uuidgen from the base image because it brings in about
30M of compressed dependencies above what the new minimal base
includes (timezone data, systemd libs, a few others). For now,
update the image to make the dependency explicit, although we
may want to remove uuidgen in the future or make it a subcommand
of the install.
Explicitly references gzip as well for convenience in gzipping logs.